Re: commit: ldap/servers/slapd/back-bdb id2entry.c

[Pierangelo Masarati <ando@sys-net.it>]

Howard Chu wrote:
> ando@OpenLDAP.org wrote:
> > Update of /repo/OpenLDAP/pkg/ldap/servers/slapd/back-bdb
> >
> > Modified Files:
> >     id2entry.c  1.87 ->  1.88
> >
> > Log Message:
> > don't dereference NULL pointers (ITS#5676)
> Nice catch. But, since txn's are always being used now, you should 
> simply have changed the outer "if (txn)" to "if (boi)".

Right; but it looks cleaner like this: txn != NULL => can retry; boi != 
NULL => can record error code :)

p.


Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
-----------------------------------
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Fax:     +39 0382 476497
Email:   ando@sys-net.it
-----------------------------------