[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd/back-bdb id2entry.c

To: ando@OpenLDAP.org
Subject: Re: commit: ldap/servers/slapd/back-bdb id2entry.c
From: Howard Chu <hyc@symas.com>
Date: Tue, 02 Sep 2008 12:06:35 -0700
Cc: OpenLDAP Commit <openldap-commit2devel@OpenLDAP.org>
In-reply-to: <200809021858.m82IwZDn008623@cantor.openldap.org>
References: <200809021858.m82IwZDn008623@cantor.openldap.org>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; rv:1.9.0.2pre) Gecko/2008083002 Lightning/0.6a1 SeaMonkey/2.0a1pre

ando@OpenLDAP.org wrote:

Update of /repo/OpenLDAP/pkg/ldap/servers/slapd/back-bdb

Modified Files:
	id2entry.c  1.87 ->  1.88

Log Message:
don't dereference NULL pointers (ITS#5676)

Nice catch. But, since txn's are always being used now, you should simply have changed the outer "if (txn)" to "if (boi)".

--
  -- Howard Chu
  CTO, Symas Corp.           http://www.symas.com
  Director, Highland Sun     http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/

Follow-Ups:
- Re: commit: ldap/servers/slapd/back-bdb id2entry.c
  - From: Pierangelo Masarati <ando@sys-net.it>

Next by Date: Re: commit: ldap/servers/slapd/back-bdb id2entry.c
Index(es):
- Chronological
- Thread