[Date Prev][Date Next]
[Chronological]
[Thread]
[Top]
Re: Using LMDB safely with fork() and exec()
- To: Lorenz Bauer <lmb@cloudflare.com>
- Subject: Re: Using LMDB safely with fork() and exec()
- From: Hallvard Breien Furuseth <h.b.furuseth@usit.uio.no>
- Date: Wed, 7 Sep 2016 14:00:58 +0200
- Cc: openldap-technical@openldap.org
- In-reply-to: <CACAyw9-Ep_5fknhXsAhw+BTk0_fZSn=P=LEtVXgC4Fp+ze=VZQ@mail.gmail.com>
- References: <CACAyw99UKOXtHKxHToAg2aheQbEREpecuEC=w6zjBcPpS-jV-g@mail.gmail.com> <4f48fc59-b11e-8ed7-38ac-8c5091eb7776@usit.uio.no> <CACAyw98dQu0cHYxQnAaNyU0x-isAhBqDBHK+NiW82uK=4g5CYw@mail.gmail.com> <2fdda0a0-fe55-97dd-59ac-8adb4b760933@usit.uio.no> <CACAyw98+93HRNLAYjypeRg3pyjMwfbkJCduP3e76bX6GxG7FYQ@mail.gmail.com> <06b7d04d-4a10-b3d6-1587-cb7a5932f877@usit.uio.no> <27925844-a6b0-eb07-e1bd-a1d4ffce3536@usit.uio.no> <CACAyw9-Ep_5fknhXsAhw+BTk0_fZSn=P=LEtVXgC4Fp+ze=VZQ@mail.gmail.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2
On 07. sep. 2016 12:22, Lorenz Bauer wrote:
Would it make sense to split the main commit into two for fname and fopen
changes?
Go ahead, or I'll do it later. Will need to add a function
mdb_fname_suffix_set() which disappears again in the next commit
(merged into mdb_fopen).
Also, I find the flags = which == MDB_O_* rather hard to follow.
Maybe that is better as a switch?
Well. It was supposed to be formatted to be easy to read.
But note that lmdb (and openldap) code uses tab-width = 4, not 8.
Same as indentation.
Anyway, I've repaced one tab with 4 spaces so it lines up either way,
and replaced the Windows if-else with switch while I was at it.
git filter-branch is nice:-)
--
Hallvard