[Date Prev][Date Next]
[Chronological]
[Thread]
[Top]
Re: LMDB and text encoding
- To: Timur Kristóf <timur.kristof@gmail.com>, openldap-devel@openldap.org
- Subject: Re: LMDB and text encoding
- From: Howard Chu <hyc@symas.com>
- Date: Sun, 01 Feb 2015 23:40:37 +0000
- In-reply-to: <CAFF-SiUPjzqs6RcXQRDL4e9xevu22AHuZqBGv=y_2Uyfagw2DQ@mail.gmail.com>
- References: <CAFF-SiUrJKGvG_z5vKgn13KX6oSbWQmLDj0VqGXMsuzJT5JBEg@mail.gmail.com> <CAFF-SiWh0Gv4Lo6SYwNcuZUCC2PcUDGZ24V0fP7hXnrx_e9PTw@mail.gmail.com> <CAFF-SiV0Q1xxxQdGKCCFsmR+1Wt1jtSpSNoaGo_2UU_0jzTXLg@mail.gmail.com> <CAFF-SiUPjzqs6RcXQRDL4e9xevu22AHuZqBGv=y_2Uyfagw2DQ@mail.gmail.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:37.0) Gecko/20100101 Firefox/37.0 SeaMonkey/2.34a1
Timur Kristóf wrote:
Hi,
I forgot to add an ENOMEM check. I added it now. I think this patch is
ready for Howard and Hallvard to review. :)
It looks OK to me. No one raises any concerns I'll commit it in a few hours.
Timur
On Thu, Jan 29, 2015 at 2:42 PM, Timur Kristóf <timur.kristof@gmail.com> wrote:
Here is a fixed version of the patch.
On Thu, Jan 29, 2015 at 10:29 AM, Timur Kristóf <timur.kristof@gmail.com> wrote:
mdb_dbi_open treats its name parameter as a C string. This means UTF-8 on
unixes and ANSI on Windows, which is problematic for cross-platform
applications. [...]
Here is a patch that addresses this concern.
If you like it, I'll move on to the other issue.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/