[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd backend.c

To: "Hallvard B Furuseth" <h.b.furuseth@usit.uio.no>
Subject: Re: commit: ldap/servers/slapd backend.c
From: masarati@aero.polimi.it
Date: Sat, 21 Nov 2009 21:25:51 +0100 (CET)
Cc: OpenLDAP Commit <openldap-commit2devel@openldap.org>, hyc@openldap.org
Importance: Normal
In-reply-to: <hbf.20091121fakw@bombur.uio.no>
References: <200911211922.nALJMISY061915@cantor.openldap.org> <hbf.20091121fakw@bombur.uio.no>
User-agent: SquirrelMail/1.4.9a

> hyc@OpenLDAP.org writes:
>> 	backend.c  1.412 -> 1.413
>> ITS#6393 syncrepl internal connids are now <= -1000
>
> backend.c: 'op->o_connid <= -1000' is wrong. o_connid is unsigned long,
> so this is compiled as 'op->o_connid <= (unsigned long) -1000'.

Right.  Also, since o_connid is unsigned long, -1000-rid is a valid connid.

Perhaps, a char in the Connection structure, or yet another value in some
bitmask would be better.

p.

Follow-Ups:
- Re: commit: ldap/servers/slapd backend.c
  - From: Howard Chu <hyc@symas.com>

References:
- Re: commit: ldap/servers/slapd backend.c
  - From: Hallvard B Furuseth <h.b.furuseth@usit.uio.no>

Prev by Date: Re: commit: ldap/servers/slapd backend.c
Next by Date: Re: commit: ldap/servers/slapd backend.c
Index(es):
- Chronological
- Thread