[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/libraries/libldap deref.c Makefile.in

To: Pierangelo Masarati <ando@sys-net.it>
Subject: Re: commit: ldap/libraries/libldap deref.c Makefile.in
From: Quanah Gibson-Mount <quanah@zimbra.com>
Date: Mon, 10 Nov 2008 15:36:18 -0800
Cc: OpenLDAP Commit <openldap-commit2devel@openldap.org>
Content-disposition: inline
In-reply-to: <4918C337.40702@sys-net.it>
References: <200811101915.mAAJFGYK006329@cantor.openldap.org> <4918C337.40702@sys-net.it>

--On Tuesday, November 11, 2008 12:26 AM +0100 Pierangelo Masarati <ando@sys-net.it> wrote:

quanah@OpenLDAP.org wrote:

Update of /repo/OpenLDAP/pkg/ldap/libraries/libldap

Modified Files:
      Tag: OPENLDAP_REL_ENG_2_4
	Makefile.in  1.79.2.6 -> 1.79.2.7
Added Files:
      Tag: OPENLDAP_REL_ENG_2_4
	deref.c  NONE -> 1.2.2.1

Log Message:
ITS#5768


This commit breaks 2.4 because LDAP_CONTROL_X_DEREF is only defined when
LDAP_DEVEL is, but it is used in libldap/deref.c without #ifdef.
Probably, the macro declaration should be moved outside #ifdef
LDAP_DEVEL.  I don't want to intervene while you're consolidating 2.4,
though.

Feel free to fix it, I've caught up on 2.4 commits, and am currently looking at the diff between HEAD/RE24.

--Quanah

--

Quanah Gibson-Mount
Principal Software Engineer
Zimbra, Inc
--------------------
Zimbra ::  the leader in open source messaging and collaboration

References:
- Re: commit: ldap/libraries/libldap deref.c Makefile.in
  - From: Pierangelo Masarati <ando@sys-net.it>

Prev by Date: Re: commit: ldap/libraries/libldap deref.c Makefile.in
Next by Date: Re: commit: ldap/libraries/libldap deref.c Makefile.in
Index(es):
- Chronological
- Thread