[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/tests/scripts test049-sync-config

To: ando@OpenLDAP.org
Subject: Re: commit: ldap/tests/scripts test049-sync-config
From: Howard Chu <hyc@symas.com>
Date: Sun, 28 Jan 2007 01:52:28 -0800
Cc: OpenLDAP Commit <openldap-commit2devel@OpenLDAP.org>
In-reply-to: <200701280935.l0S9Zo3v040261@cantor.openldap.org>
References: <200701280935.l0S9Zo3v040261@cantor.openldap.org>
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070125 Netscape/7.2 (ax) Firefox/1.5 SeaMonkey/1.5a

ando@OpenLDAP.org wrote:

Update of /repo/OpenLDAP/pkg/ldap/tests/scripts

Modified Files:
	test049-sync-config  1.3 -> 1.4

Log Message:
make sure replication finished before comparing data (under valgrind, replication may take ages)

I debated adding such a check before. I think the first check you added should be removed. In my initial testing there were timing-dependent errors that cropped up when refreshing was occurring while the ldapadd was running. I think it's important that we continue to test for this case, however crudely it's done. Too bad we don't have a reliable means to notify the test script when the consumer has actually started its work. We could query back-monitor but normally (not under valgrind) the refresh could complete before we got the back-monitor search result.

--
  -- Howard Chu
  Chief Architect, Symas Corp.  http://www.symas.com
  Director, Highland Sun        http://highlandsun.com/hyc
  OpenLDAP Core Team            http://www.openldap.org/project/

Follow-Ups:
- Re: commit: ldap/tests/scripts test049-sync-config
  - From: "Pierangelo Masarati" <ando@sys-net.it>

Prev by Date: Re: syncrepl
Next by Date: Re: commit: ldap/tests/scripts test049-sync-config
Index(es):
- Chronological
- Thread