[Date Prev][Date Next]
[Chronological]
[Thread]
[Top]
controls state data leakage
- To: OpenLDAP Devel <openldap-devel@OpenLDAP.org>
- Subject: controls state data leakage
- From: Pierangelo Masarati <ando@sys-net.it>
- Date: Sun, 04 Sep 2005 19:59:57 +0200
- User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050524 CentOS/1.7.8-1.1.3.1.centos3
Howard,
I note that controls state data that is stored in o_controls[id] doesn't
leak only because it's allocated on the operation's slab. I noted that
for the pagedResults, but it may well occur for other controls. Was
this intended? Otherwise, we could put in slap_free_ctrls() a
op->o_tmpfree() for each o_controls[i] that is non-zero, unless it's
acceptable that controls store there memory that is not allocated with
o_tmp* routines. The other solution is to provide cleanup hooks for
each control, and call it, when defined, for all controls that are set.
This solution would be far more general, but it requires som work.
p.
SysNet - via Dossi,8 27100 Pavia Tel: +390382573859 Fax: +390382476497