Re: Incomplete slapi_int_ldapmods2modifications() change

[Luke Howard <lukeh@padl.com>]

Well spotted -- should always be TRUE.

-- Luke

>From: Hallvard B Furuseth <h.b.furuseth@usit.uio.no>
>Subject: Incomplete slapi_int_ldapmods2modifications() change
>To: lukeh@openldap.org
>Cc: OpenLDAP Commit <openldap-commit2devel@openldap.org>
>Date: Tue, 02 Aug 2005 15:00:45 +0200
>
>slapi/slapi_utils.c rev 1.172 removed the 'dup' parameter to
>slapi_int_ldapmods2modifications(), but a 'dup' test remains in the
>function body.  (It evaluates to the address of the function dup().)
>
>> Add slapi_dn_isbesuffix()
>> Fix slapi_dn_beparent() logic
>> Fix slapi_int_ldapmods2modifications() memory management, values
>> always need to be duplicated because of prettying in slap_mods_check()
>
>-- 
>Hallvard

--