[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd controls.c sl_malloc.c slap.h



Howard Chu wrote:

ando@OpenLDAP.org wrote:

Update of /repo/OpenLDAP/pkg/ldap/servers/slapd

Modified Files:
    controls.c  1.122 -> 1.123
    sl_malloc.c  1.20 -> 1.21
    slap.h  1.605 -> 1.606

Log Message:
make unregistered known controls show up as undefined; move LDAPsync cid to frontend; some cleanup


Unfortunately this patch has broken test015 (control not available in context) because the backends reference slap_known_controls, not slap_known_controls+1.

I think we can still use this idea, just using another offset. If we define slap_known_controls to point to the second element of an array, we can use "-1" as the undefined initializer and array[-1] will be the unused/NULL entry.

OK; then we need to initialize to -1 all the cids.

p.





   SysNet - via Dossi,8 27100 Pavia Tel: +390382573859 Fax: +390382476497