[Date Prev][Date Next] [Chronological] [Thread] [Top]

FW: commit: ldap/servers/slapd/back-bdb add.c attribute.c back-bdb.h delete.c group.c modify.c modrdn.c passwd.c



Hm... This code assumes that if bdb_group fails to get a lock, the particular
access_allowed() call will eventually fail. But if some other ACL allows the
operation to succeed anyway, then the DB lock failure won't propagate back to
the original operation. I suppose that's ok, but then in the main operation
we should only look at opinfo.boi_err if access_allowed actually fails.

  -- Howard Chu
  Chief Architect, Symas Corp.       Director, Highland Sun
  http://www.symas.com               http://highlandsun.com/hyc
  Symas: Premier OpenSource Development and Support

-----Original Message-----
From: owner-openldap-commit@OpenLDAP.org
[mailto:owner-openldap-commit@OpenLDAP.org]On Behalf Of hyc@OpenLDAP.org
Sent: Wednesday, February 26, 2003 3:09 AM
To: OpenLDAP Commit
Subject: commit: ldap/servers/slapd/back-bdb add.c attribute.c
back-bdb.h delete.c group.c modify.c modrdn.c passwd.c


Update of /repo/OpenLDAP/pkg/ldap/servers/slapd/back-bdb

Modified Files:
	add.c  1.68 -> 1.69
	attribute.c  1.24 -> 1.25
	back-bdb.h  1.71 -> 1.72
	delete.c  1.63 -> 1.64
	group.c  1.25 -> 1.26
	modify.c  1.62 -> 1.63
	modrdn.c  1.86 -> 1.87
	passwd.c  1.41 -> 1.42

Log Message:
Fix attribute/group to allow TXN to abort on lock failure. Save and
restore op->o_do_not_cache on TXN retry, bdb_group will set it if it
fails to get a lock.


CVS Web URLs:
  http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/back-bdb/
    http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/back-bdb/add.c

http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/back-bdb/attribute.c

http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/back-bdb/back-bdb.h
    http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/back-bdb/delete.c
    http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/back-bdb/group.c
    http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/back-bdb/modify.c
    http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/back-bdb/modrdn.c
    http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/back-bdb/passwd.c

Changes are generally available on cvs.openldap.org (and CVSweb)
within 30 minutes of being committed.