[Date Prev][Date Next]
[Chronological]
[Thread]
[Top]
Re: OpenLDAP 2.0-Beta now available
At 01:43 PM 7/13/00 -0700, Anthony Brock wrote:
>Forgive me if I am posting to the wrong list. However, I have never tried to post a suggested fix before.
This is the right list for discussing devel/beta issues
including submitted patches. However, the patches
themselves should be submitted to our Issue Tracking
System <http://www.openldap.org/its/> per our contributing
guidelines <http://www.openldap.org/devel/contributing.html>.
>I have downloaded the beta, and it appears to be reasonably stable.
Good to hear. Folks have been quite (which is usually a good sign).
> Bugs I encountered included:
>
>1) Inability to add values of type 'uniqueMember' to a 'groupOfUniqueNames' objectclass without the server returning errors.
This is because the syntax ('Name and Optional UID') and matching
rule ('uniqueMemberMatch') associated with that attribute have
not been implemented. I purposely did not reuse DN syntax/matchrule
routines as I presumed folks choosing to use uniqueMember over
member was likely doing so because of the optional UID semantics.
>2) What appears to be a parsing bug when using extended group attributes such as:
>
>group/objectclassname/attribute=<group regex>
This change appears okay...
>I have attached and included below both modifications I made to the source code in order to get this working. Let me know if I have introduced some other major bugs :)
It's generally advised to submit one patch per issue, one issue
per patch. Also, use of diff -u (especially cvs diff -u)
appreciated.
>Tony
>
>diff -c -r openldap-2.0-beta.orig/servers/slapd/aclparse.c openldap-2.0-beta/servers/slapd/aclparse.c
>*** openldap-2.0-beta.orig/servers/slapd/aclparse.c Tue Jul 4 10:58:54 2000
>--- openldap-2.0-beta/servers/slapd/aclparse.c Wed Jul 12 20:29:30 2000
>***************
>*** 487,493 ****
> }
>
> if (name && *name) {
>! rc = slap_str2ad( right, &b->a_group_at, &text );
>
> if( rc != LDAP_SUCCESS ) {
> fprintf( stderr,
>--- 487,493 ----
> }
>
> if (name && *name) {
>! rc = slap_str2ad( name, &b->a_group_at, &text );
>
> if( rc != LDAP_SUCCESS ) {
> fprintf( stderr,
>diff -c -r openldap-2.0-beta.orig/servers/slapd/schema_init.c openldap-2.0-beta/servers/slapd/schema_init.c
>*** openldap-2.0-beta.orig/servers/slapd/schema_init.c Tue Jul 4 10:58:55 2000
>--- openldap-2.0-beta/servers/slapd/schema_init.c Mon Jul 10 10:29:57 2000
>***************
>*** 1598,1604 ****
> {"( 1.3.6.1.4.1.1466.115.121.1.33 DESC 'MHS OR Address' )",
> 0, NULL, NULL, NULL},
> {"( 1.3.6.1.4.1.1466.115.121.1.34 DESC 'Name And Optional UID' )",
>! 0, NULL, NULL, NULL},
> {"( 1.3.6.1.4.1.1466.115.121.1.35 DESC 'Name Form Description' )",
> 0, NULL, NULL, NULL},
> {"( 1.3.6.1.4.1.1466.115.121.1.36 DESC 'Numeric String' )",
>--- 1598,1604 ----
> {"( 1.3.6.1.4.1.1466.115.121.1.33 DESC 'MHS OR Address' )",
> 0, NULL, NULL, NULL},
> {"( 1.3.6.1.4.1.1466.115.121.1.34 DESC 'Name And Optional UID' )",
>! 0, dnValidate, dnNormalize, dnPretty},
> {"( 1.3.6.1.4.1.1466.115.121.1.35 DESC 'Name Form Description' )",
> 0, NULL, NULL, NULL},
> {"( 1.3.6.1.4.1.1466.115.121.1.36 DESC 'Numeric String' )",
>
>
>
>
>diff -c -r openldap-2.0-beta.orig/servers/slapd/aclparse.c openldap-2.0-beta/servers/slapd/aclparse.c
>*** openldap-2.0-beta.orig/servers/slapd/aclparse.c Tue Jul 4 10:58:54 2000
>--- openldap-2.0-beta/servers/slapd/aclparse.c Wed Jul 12 20:29:30 2000
>***************
>*** 487,493 ****
> }
>
> if (name && *name) {
>! rc = slap_str2ad( right, &b->a_group_at, &text );
>
> if( rc != LDAP_SUCCESS ) {
> fprintf( stderr,
>--- 487,493 ----
> }
>
> if (name && *name) {
>! rc = slap_str2ad( name, &b->a_group_at, &text );
>
> if( rc != LDAP_SUCCESS ) {
> fprintf( stderr,
>diff -c -r openldap-2.0-beta.orig/servers/slapd/schema_init.c openldap-2.0-beta/servers/slapd/schema_init.c
>*** openldap-2.0-beta.orig/servers/slapd/schema_init.c Tue Jul 4 10:58:55 2000
>--- openldap-2.0-beta/servers/slapd/schema_init.c Mon Jul 10 10:29:57 2000
>***************
>*** 1598,1604 ****
> {"( 1.3.6.1.4.1.1466.115.121.1.33 DESC 'MHS OR Address' )",
> 0, NULL, NULL, NULL},
> {"( 1.3.6.1.4.1.1466.115.121.1.34 DESC 'Name And Optional UID' )",
>! 0, NULL, NULL, NULL},
> {"( 1.3.6.1.4.1.1466.115.121.1.35 DESC 'Name Form Description' )",
> 0, NULL, NULL, NULL},
> {"( 1.3.6.1.4.1.1466.115.121.1.36 DESC 'Numeric String' )",
>--- 1598,1604 ----
> {"( 1.3.6.1.4.1.1466.115.121.1.33 DESC 'MHS OR Address' )",
> 0, NULL, NULL, NULL},
> {"( 1.3.6.1.4.1.1466.115.121.1.34 DESC 'Name And Optional UID' )",
>! 0, dnValidate, dnNormalize, dnPretty},
> {"( 1.3.6.1.4.1.1466.115.121.1.35 DESC 'Name Form Description' )",
> 0, NULL, NULL, NULL},
> {"( 1.3.6.1.4.1.1466.115.121.1.36 DESC 'Numeric String' )",
>******************************************************************************
>* Anthony Brock abrock@georgefox.edu *
>* Director of Network Services George Fox University *
>******************************************************************************