[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8714)



hyc@symas.com wrote:
> There's a weird indent at extended.c:50 or so, the if()
> statement.
>
> Would be better to use op->o_tmpalloc instead of ber_memalloc
> since you'r= e=20 immediately freeing the buffer again anyway.
>
> I can fix those here if you don't care.

Yes, I'd highly appreciate if you simply adjust it to your coding 
style.

One additional point:
Currently the external program is not able to produce a custom 
extended operation response. Mainly it should always return 
CONTINUE or an error response. I wanted to make this limitation 
clear in the man-page but was unsure about the appropriate section.

Ciao, Michael.