[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6645) Yet Another LDIF Wrap Patch



> hyc@symas.com writes:
>> Not thrilled with the magic constant 2^31-1. Seems like you should have
>> just
>> used "if ( wrap && len > wrap )" instead of a word-size-dependent magic.
>
> The code just needs to be a little less clever:-)  Pass -1 to a
> 'ber_len_t wrap'.  The constant (ber_len_t)-1 will prevent wrapping:
> "if (len > (ber_len_t)-1)" always fails.

<ftp://ftp.openldap.org/incoming/pierangelo-masarati-2010-09-09-ldif-wrap.3.patch>

Includes documentation.  Thanks for checking this.

p.