[Date Prev][Date Next]
[Chronological]
[Thread]
[Top]
Re: (ITS#6324) slapd -d ? emits incorrect value for LDAP_DEBUG_ANY on x86_64
- To: openldap-its@OpenLDAP.org
- Subject: Re: (ITS#6324) slapd -d ? emits incorrect value for LDAP_DEBUG_ANY on x86_64
- From: jwm@horde.net
- Date: Tue, 6 Oct 2009 16:50:53 GMT
- Auto-submitted: auto-generated (OpenLDAP-ITS)
The 32-bit value 4294967295 for LDAP_DEBUG_ANY is also rejected.
lutil_atoix() declares i as type long and tries to check for overflow(?)
with this cast:
if ( (long)(int)i != i ) {
which always fails in this case on x86_64. lutil_atoux() might be the more
appropriate choice here.
str2loglevel() seems to behave correctly by virtue of verb_to_mask()
returning an index into loglevel_ops, but I haven't checked extensively.
loglevel_init(), however, does specify a hardcoded -1 for the Any level
instead of LDAP_DEBUG_ANY.
john
--
John Morrissey _o /\ ---- __o
jwm@horde.net _-< \_ / \ ---- < \,
www.horde.net/ __(_)/_(_)________/ \_______(_) /_(_)__