Re: (ITS#5804) attribute value regex expantion

[ando@sys-net.it]

quanah@zimbra.com wrote:
> --On Saturday, November 29, 2008 5:32 AM +0000 manu@netbsd.org wrote:
> 
>> Quanah Gibson-Mount <quanah@zimbra.com> wrote:
>>
>>> IIRC, this also broke ACI's in RE2.4, and that still needs fixing as
>>> well.
>> Did it? Where is the report about that?
> 
> Can't find it atm, but I remember someone writing in about ACI's being 
> broken in HEAD right now, and I believe it was related to this change. 
> RE2.4 was a typo on my part, since this isn't in RE24 right now.

Yes (I think it was Hallvard).  ACIs broke since acl_string_expand() 
changed prototype, but the number of args was the same, and compiling 
succeeded with a warning (which I didn't notice, btw).  To make it 
worse, test041 did not fail (apparently, it makes no use of string 
expansion).  Now it's fixed; I'd say hacked, since I did not want to 
change the API of dynacl, yet.  Changing the API should not be a big 
deal, given the presumably limited number of custom dynacl 'round.

p.


Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
-----------------------------------
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Fax:     +39 0382 476497
Email:   ando@sys-net.it
-----------------------------------