[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5798) MMR/mirror mode circumvents schema check



ando@sys-net.it wrote:
> ando@sys-net.it wrote:
>> Full_Name: Pierangelo Masarati
>> Version: HEAD/re24
>> OS: irrelevant
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (82.63.140.131)
>> Submitted by: ando
>>
>>
>> When syncrepl is configured, schema checking is switched off.  As a consequence,
>> schema checking does not occur for all writes, including direct writes from
>> clients when MMR/MM is in use.
>>
>> Internal writes performed by syncrepl should be marked as such, in order to
>> disable schema checking only when appropriate.
>
> It all seems to boil down to the fact that syncrepl schemachecking is
> off by default.  So, not specifying any results in having multimasters
> with schemachecking disabled, which is not desirable.  I recommend
> schema checking be on by default.

All we have to do is change the code from setting the DB flag to using the 
per-op o_no_schema_check flag. IMO defaulting schemacheck off for replication 
is fine because replicated entries will have been checked on the master.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/