[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5340) REP_ENTRY_MODIFIABLE bug in dynlist



Howard Chu writes:
> I have the feeling that MUSTBEFREED and MUSTRELEASE should be
> consolidated into a single flag. be_entry_release_r() should simply
> call entry_free() if e->e_private is NULL.

Maybe.  But consider translucent - it grabs incoming entries and
remembers them.  It can "steal" a MUSTBEFREED entry (though it doesn't
now), but must duplicate a MUSTRELEASE entry so that it won't hold on to
a lock in an underlying database.

-- 
Hallvard