Re: (ITS#5341) Invalid TLSCipherSuite causes hang

[kyle@moffetthome.net]

On Jan 31, 2008 7:43 AM, Kyle Moffett <kyle@moffetthome.net> wrote:
> On Jan 31, 2008 12:29 AM, Kyle Moffett <kyle@moffetthome.net> wrote:
> > I ran into this problem a little while ago and scribbled up the
> > attached patch to fix it.  It's trivial enough and it works in my
> > testing here.
>
> Sorry, the patch seems to have gone out MIME-encoded and mostly
> useless to people who want to download it from the bug-tracker.  Let
> me try again... (Sorry, still getting used to a new email client)

Well damn, it still didn't work.  Hopefully gmail won't mangle a
pasted patch.  Again, my apologies for the mess.

Cheers,
Kyle Moffett

--- openldap-2.4.7/libraries/libldap/tls.c.orig	2007-12-21
19:24:08.000000000 -0500
+++ openldap-2.4.7/libraries/libldap/tls.c	2007-12-21 19:36:02.000000000 -0500
@@ -300,6 +300,7 @@
 		for (i=0; i<n_ciphers; i++) {
 			if ( !strncasecmp( ciphers[i].name, ptr, len )) {
 				num++;
+				ptr = end + 1;
 				break;
 			}
 		}
@@ -330,6 +331,7 @@
 			 * only appear once in each list.
 			 */
 			if ( !strncasecmp( ciphers[i].name, ptr, len )) {
+				ptr = end + 1;
 				for (j=0; j<nkx; j++)
 					if ( kx[j] == ciphers[i].kx )
 						break;