(ITS#5276) include handler broken

[quanah@zimbra.com]

Full_Name: Quanah Gibson-Mount
Version: 2.3.39
OS: Linux 2.6
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (66.92.25.194)


In discussions with a fellow on IRC, it looks like the include handler has some
serious problems.  For example with this slapd.conf, we get:

#ucdata-path    "/opt/zimbra/openldap/ucdata"
include         "/opt/zimbra/openldap/etc/openldap/schema/core.schema"
include         "/opt/zimbra/openldap/etc/openldap/schema/cosine.schema"
include         "/opt/zimbra/openldap/etc/openldap/schema/inetorgperson.schema"
include         "/opt/zimbra/openldap/etc/openldap/schema/amavisd.schema"
include         "/opt/zimbra/openldap/etc/openldap/schema/zimbra.schema"
include         "/opt/zimbra/lib/conf/zimbra-ext.schema"

threads         8

pidfile         "/opt/zimbra/openldap/var/run/slapd.pid"
argsfile        "/opt/zimbra/openldap/var/run/slapd.args"

TLSCertificateFile /opt/zimbra/conf/slapd.crt
TLSCertificateKeyFile /opt/zimbra/conf/slapd.key
TLSVerifyClient never

loglevel 32768

# Load dynamic backend modules:
modulepath      /opt/zimbra/openldap/libexec/openldap
moduleload      back_bdb.la
moduleload      back_monitor.la
moduleload      syncprov.la
moduleload      accesslog.la

<acl lines snipped>

database        config
rootpw {SSHA}+wKEnqbcbxssdGDKx1LeNsoL90Ha2Lzx

database        monitor
rootdn          "cn=config"
access to dn.children="cn=monitor"
        by dn.children="cn=admins,cn=zimbra" read

include /opt/zimbra/conf/bdb-conf
include /opt/zimbra/conf/syncrepl-conf

bdb-conf is:

database        bdb
suffix          ""
rootdn          "cn=config"
cachesize 10000
idlcachesize 10000
checkpoint 64 5
directory       "/opt/zimbra/openldap-data"
index   objectClass                 eq
sizelimit unlimited
timelimit unlimited


And we can see it is clearly processed, so why is the syncrepl line getting
tagged to the monitor backend?

line 47 (index   entryCSN               eq)
index entryCSN 0x0004
line 48 (sizelimit unlimited)
line 49 (timelimit unlimited)
line 154 (include /opt/zimbra/conf/syncrepl-conf)
reading config file /opt/zimbra/conf/syncrepl-conf
line 13 (syncrepl ***)
/opt/zimbra/conf/syncrepl-conf: line 13: database monitor does not support
operations required for syncrepl
/opt/zimbra/conf/slapd.conf: line 154: <include> handler exited with 1!


Another example of this problem can be seen at:

http://pastebin.com/d16e9b905