[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5227) old dsn acceptance



aej@wpi.edu wrote:
> Full_Name: Allan E. Johannesen
> Version: 2.4.6
> OS: Linux EL 4
> URL: http://users.wpi.edu/~aej/schema_init.diff
> Submission from: (NULL) (130.215.24.208)
> 
> 
> Old CSN stamps are not accepted by 2.4.6.  I guess they must be _very_ old,
> since there is a "2/3" CSN conversion in the release.
> 
> The stamps are of the form: YYYYMMDDHH:MM:SSZ

That's the format from when CSNs were introduced in OpenLDAP 2.1.

> Perhaps I'm the only person in the OpenLDAP universe who might see this problem,
> but I adapted the 2/3 conversion for these old fields.

It seems a bit odd to be introducing support for that format now in 2.4, when 
it was completely unsupported in 2.2 and 2.3. I.e., why wasn't this issue 
raised during the migration to/thru either 2.2 or 2.3?

I'm inclined to reject this patch; you can fix it in LDIF using sed or perl 
and never have to think about it again.
-- 
   -- Howard Chu
   Chief Architect, Symas Corp.  http://www.symas.com
   Director, Highland Sun        http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP     http://www.openldap.org/project/