Re: (ITS#5197) result.c uses ldap_pvt_thread_pool_query indiscriminately

[hyc@symas.com]

richton@nbcs.rutgers.edu wrote:
> Full_Name: Aaron Richton
> Version: RE24
> OS: irrelevant
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (128.6.31.135)
> 
> 
> ldap_pvt_thread_pool_query is referenced even if --without-threads. I believe
> this is as simple as...

Thanks for the report.
> 
> --- result.c~   2007-10-23 09:53:36.646614000 -0400
> +++ result.c    2007-10-23 09:53:23.640874000 -0400
> @@ -743,12 +743,14 @@
>                 return LDAP_SIZELIMIT_EXCEEDED;
>         }
> 
> +#ifndef NO_THREADS
>         /* Every 64 entries, check for thread pool pause */
>         if (( rs->sr_nentries & 0x3f == 0x3f ) &&
>                 ldap_pvt_thread_pool_query( &connection_pool,
>                         LDAP_PVT_THREAD_POOL_PARAM_PAUSING, &i ) == 0 && i ) {
>                 return LDAP_BUSY;
>         }
> +#endif
> 
>         rs->sr_type = REP_SEARCH;
> 
> 
> 
> .
> 


-- 
   -- Howard Chu
   Chief Architect, Symas Corp.  http://www.symas.com
   Director, Highland Sun        http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP     http://www.openldap.org/project/