(ITS#4973) Inconsistent initialization of internal modifications

[ando@sys-net.it]

Full_Name: Pierangelo Masarati
Version: HEAD
OS: irrelevant
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (81.72.89.40)
Submitted by: ando


While fixing slapo-chain(5) handling of passmods, I stumbled into an
inconsistent initialization of internal modifications.  What happens is that in
most cases the Operation structure used for internal operations is either
directly the structure passed to the function that performs the internal
operation, or a copy of it, something like

        Operation op2 = *op;

The oq_modify.rs_modlist member now contains an orm_no_opattrs field which, if
non-zero, inhibits the modification of operational attributes, and thus
indirectly breaks replication.  I've fixed the occurrence in passwd_extop(), but
the code is full of internal modifications that might need care.

p.