Re: (ITS#4930) slaptest should be quiet on success

[quanah@zimbra.com]

--On April 18, 2007 9:42:20 AM +0000 jsafranek@redhat.com wrote:

> Full_Name: Jan Safranek
> Version: 2.3.35
> OS: Linux (Fedora 6)
> URL:
> Submission from: (NULL) (62.40.79.66)
>
>
> The 'slaptest' tool is a bit verbose, it sends 'config file testing
> succeeded' to stderr. IMHO it should do not output anything, especially
> to stderr, if everything is all right.
>
> Here is a small patch, causing the slaptest to display the aforementioned
> message  only if -v switch is used:
>
> Index: servers/slapd/slaptest.c
> ===================================================================
> RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/slaptest.c,v
> retrieving revision 1.9
> diff -r1.9 slaptest.c
> 107c107,108
> <       fprintf( stderr, "config file testing succeeded\n");
> ---
>>       if (verbose)
>>               fprintf( stderr, "config file testing succeeded\n");

The point of slaptest is to tell users whether or not things are okay. 
Having slaptest exit with nothing displayed somewhat defeats that purpose...

--Quanah

--
Quanah Gibson-Mount
Principal Software Engineer
Zimbra, Inc
--------------------
Zimbra ::  the leader in open source messaging and collaboration