Re: (ITS#4911) slapadd uses slap_op_mutex uninitialized

[hyc@symas.com]

h.b.furuseth@usit.uio.no wrote:
> Full_Name: Hallvard B Furuseth
> Version: HEAD
> OS: Linux
> URL: 
> Submission from: (NULL) (129.240.202.105)
> Submitted by: hallvard
> 
> 
> slapadd uses slap_op_mutex uninitialized in operation.c:slap_op_time()

Fixed.

> Any hope of making the tools and slapd go through the same init/destroy code
> in main(), maybe by making the server just another "tool"?  Seems to me the
> only hope of making bugs like this keep popping up...

In the past the tools didn't use threads and didn't share as much code 
with slapd. As such, it seems a lot of subsystems really didn't need to 
be set up for tool mode. I guess things have changed since we now use 
Operation structures everywhere.

Tools like slappasswd don't even read the slapd config. That means you 
can't use slappasswd with a dynamically loaded password-hash module. So 
yes, some of this structuring needs to be revisited.

-- 
   -- Howard Chu
   Chief Architect, Symas Corp.  http://www.symas.com
   Director, Highland Sun        http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP     http://www.openldap.org/project/