[Date Prev][Date Next]
[Chronological]
[Thread]
[Top]
(ITS#4899) ITS4855 fix breaks 2.3.34
Full_Name: Quanah Gibson-Mount
Version: 2.3.34
OS: Linux 2.6
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (171.66.35.82)
I patched 2.3.34 with the patch in RE_23 for fixing the thread pool issue
(ITS#4855)
<http://www.openldap.org/devel/cvsweb.cgi/libraries/libldap_r/tpool.c.diff?r1=1.30.2.17&r2=1.30.2.18&hideattic=1&sortbydate=0&f=h>
My patch being:
ldap-uat00:/usr/local/build/PATCHES/openldap# cat ITS4855
--- openldap-2.3.34/libraries/libldap_r/tpool.c.orig 2007-03-26
15:19:56.000000000 -0700
+++ openldap-2.3.34/libraries/libldap_r/tpool.c 2007-03-26 15:20:20.000000000
-0700
@@ -664,7 +664,7 @@
int i;
for ( i=MAXKEYS-1; i>=0; i--) {
- if ( ctx[i].ltk_key )
+ if ( ctx[i].ltk_key == NULL )
continue;
if ( ctx[i].ltk_free )
ctx[i].ltk_free( ctx[i].ltk_key, ctx[i].ltk_data );
Now when I shut down slapd, it core dumps:
1282 cache.c: No such file or directory.
in cache.c
(gdb) bt
#0 bdb_locker_id_free (key=0x2aad2fe00628, data=0x39) at cache.c:1282
#1 0x00002aad2d0bef21 in ldap_pvt_thread_pool_context_reset
(vctx=0x2aad2d1f2260) at tpool.c:670
#2 0x000000000044e07c in slap_destroy () at init.c:304
#3 0x00000000004159f9 in main (argc=3, argv=0x7fff7de07438) at main.c:874
If I remove the patch, there is no core dump.
I see no additional related commits for this change.
--Quanah