[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#4253) val.regex broken




--On Tuesday, December 13, 2005 10:06 PM +0100 Pierangelo Masarati 
<ando@sys-net.it> wrote:

> On Tue, 2005-12-13 at 12:28 -0800, Quanah Gibson-Mount wrote:
>
>> Empty dn: values?!
>
> No, the test uses some variables defined in scripts/defines.sh as
> searchBase; since you didn't pull them in, your search used "" as
> searchBase.  To test this with 2.3, I suggest you rather stay within
> HEAD testing directory, and modify scripts/defines.sh as below:
>
> Index: tests/scripts/defines.sh
> ===================================================================
> RCS file: /repo/OpenLDAP/pkg/ldap/tests/scripts/defines.sh,v
> retrieving revision 1.134
> diff -u -r1.134 defines.sh
> --- tests/scripts/defines.sh    9 Dec 2005 11:18:29 -0000       1.134
> +++ tests/scripts/defines.sh    13 Dec 2005 20:58:42 -0000
> @@ -135,6 +135,9 @@
>  BCMP="diff -iB"
>  CMPOUT=/dev/null
>  SLAPD="../servers/slapd/slapd -s0"
> +#SLAPD="../../ldap-2.3/servers/slapd/slapd -s0"
> +#SLAPD="/usr/local/valgrind-3.0.1/bin/valgrind --tool=memcheck
> --trace-children=yes --num-callers=10 --leak-check=yes
> --show-reachable=yes ../servers/slapd/slapd -s0"
> +#SLAPD="/usr/local/valgrind-3.0.1/bin/valgrind --tool=memcheck
> --trace-children=yes --num-callers=10 --leak-check=yes
> --show-reachable=yes ../../ldap-2.3/servers/slapd/slapd -s0"
>  SLURPD=../servers/slurpd/slurpd
>  LDAPPASSWD="$CLIENTDIR/ldappasswd $TOOLARGS"
>  LDAPSASLSEARCH="$CLIENTDIR/ldapsearch $TOOLPROTO $LDAP_TOOLARGS -LLL"
>
> Then you can uncomment the version of slapd you want to use to run the
> test.

Um, the above patch does nothing with search bases, I don't see how it 
applies to what you say at all.  In fact, all it does is use different 
version of slapd, or runs it under valgrind, and there is nothing wrong 
with using "../servers/slapd/slapd -s0", since I specifically want to test 
the slapd in that location.

Perhaps there are other changes to defines.sh that have been done (I'll go 
check that now).

--Quanah

--
Quanah Gibson-Mount
Principal Software Developer
ITSS/Shared Services
Stanford University
GnuPG Public Key: http://www.stanford.edu/~quanah/pgp.html