Re: (ITS#4230) access to attr=objectClass

[ando@sys-net.it]

On Thu, 2005-12-08 at 17:49 +0000, quanah@stanford.edu wrote:
> 
> --On Wednesday, November 30, 2005 1:30 AM +0000 syrius.ml@no-log.org wrote:
> 
> Pierangelo,
> 
> Actually, something similar to this bug affects 2.3 as well, see ITS#4253

I'm not sure they are related; however, I think ACL state saving
throughout calls is broken twice; the second error is curing the first
one, so now ACLs work as expected.  To fix the second one, and have in
2.3 the very same (broken) behavior as in 2.2, we should apply the
following patch:

===================================================================
Index: acl.c
===================================================================
RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/acl.c,v
retrieving revision 1.299
diff -u -r1.299 acl.c
--- acl.c       9 Dec 2005 09:33:01 -0000       1.299
+++ acl.c       9 Dec 2005 11:42:51 -0000
@@ -135,7 +135,6 @@
        slap_access_t                   access_level;
        const char                      *attr;
        regmatch_t                      matches[MAXREMATCHES];
-       int                             st_same_attr = 0;

        assert( op != NULL );
        assert( e != NULL );
@@ -199,7 +198,7 @@
        ret = 0;
        control = ACL_BREAK;

-       if ( st_same_attr ) {
+       if ( state && state->as_vd_ad == desc && state->as_vd_acl != NULL ) {
                assert( state->as_vd_acl != NULL );

                a = state->as_vd_acl;
===================================================================

However, I'm not going to.

p.




Ing. Pierangelo Masarati
Responsabile Open Solution

SysNet s.n.c.
Via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
------------------------------------------
Office:   +39.02.23998309          
Mobile:   +39.333.4963172
Email:    pierangelo.masarati@sys-net.it
------------------------------------------