Re: (ITS#3453) Permissive modify broken in 2.2

[ando@sys-net.it]

Agree, better leave the test for the control outside modify_add_values(),
so it can be used (and it is) for other purposes.   I've tested and
committed the suggested fix to HEAD/re22.

Ciao, p.

>
> Right - but I don't think the solution is to set SLAP_CTRL_FRONTEND,
> because modify_add_values() is just a helper routine.
>
> -- Luke
>
>>From: Pierangelo Masarati <ando@sys-net.it>
>>Subject: Re: (ITS#3453) Permissive modify broken in 2.2
>>To: lukeh@padl.com
>>Cc: openldap-its@OpenLDAP.org
>>Date: Tue, 28 Dec 2004 10:02:58 +0100
>>
>>Then the same problem occurs in all backends that call
>>modify_add_values(), the frontend function that honors the control.
>>
>>Ciao, p.
>>
>>lukeh@padl.com wrote:
>>
>>>Full_Name: Luke Howard
>>>Version: 2.2.19
>>>OS: Linux
>>>URL: ftp://ftp.openldap.org/incoming/
>>>Submission from: (NULL) (203.13.32.70)
>>>
>>>
>>>Permissive modify is broken, it seems.
>>>
>>>Index: init.c
>>>===================================================================
>>>RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/back-bdb/init.c,v
>>>retrieving revision 1.132.2.13
>>>diff -u -r1.132.2.13 init.c
>>>--- init.c      24 Nov 2004 05:02:18 -0000      1.132.2.13
>>>+++ init.c      28 Dec 2004 08:50:39 -0000
>>>@@ -569,6 +569,9 @@
>>>                LDAP_CONTROL_SUBENTRIES,
>>> #endif
>>>                LDAP_CONTROL_VALUESRETURNFILTER,
>>>+#ifdef LDAP_CONTROL_X_PERMISSIVE_MODIFY
>>>+               LDAP_CONTROL_X_PERMISSIVE_MODIFY,
>>>+#endif
>>>                NULL
>>>        };
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>>
>>    SysNet - via Dossi,8 27100 Pavia Tel: +390382573859 Fax:
>> +390382476497
>>
>
> --
>


-- 
Pierangelo Masarati
mailto:pierangelo.masarati@sys-net.it


    SysNet - via Dossi,8 27100 Pavia Tel: +390382573859 Fax: +390382476497