ldap_sasl_interactive_bind_s() generates internal error in cyrus sasl (ITS#2475)

[john@tellurian.com.au]

Full_Name: John Brazel
Version: 2.1.17
OS: NetBSD 1.6
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (203.166.57.11)


Using OpenLDAP 2.1.17, cyrus-sasl 2.1.13.

ldap_int_sasl_bind() attempts to (needlessly) query a bunch of SASL properties
(SASL_USERNAME, SASL_DEFUSERREALM) unless the LDAP_SASL_QUIET flag is specified
upon invocation (see lines 745-752 of cyrus.c 1.45.2.17).

Unless ld->lconn_sasl_ctx->type == SASL_CONN_SERVER (which as far as I can see,
is impossible, given LDAP only ever calls sasl_client_new(), and not
sasl_server_new()), querying the SADL_DEFUSERREALM property cause the cyrus sasl
libraries to generate an internal error.

Fix: Remove offending lines [745-752] from cyrus.c.


(The bug itself is hardly worth mentioning, given that the internal error
generated by cyrus sasl is non-fatal, but it does write diagnostics to stderr,
and there's no real reason for the offending code to be there in the first
place).