RE: ldap_sasl_interactive_bind_s leaks? (ITS#2423)

[igor@ipass.net]

On Sat, 5 Apr 2003, Howard Chu wrote:

> > -----Original Message-----
> > From: owner-openldap-bugs@OpenLDAP.org
> > [mailto:owner-openldap-bugs@OpenLDAP.org]On Behalf Of igor@ipass.net
>
> > Full_Name: Igor Brezac
> > Version: 2.1.16
> > OS: Solaris 9
> > URL:
> > ftp://ftp.openldap.org/incoming/ldap_sasl_interactive_bind_s.leak.c
> > Submission from: (NULL) (209.170.129.80)
> >
> >
> > My testing shows a leak in ldap_sasl_interactive_bind_s().  I
> > tried to chase the
> > leak with fnccheck, but after compiling both openldap and my
> > testing program for
> > profiling, fncdump dumps itself.
>
> It works for me...

It works fine if I profile just the test program.  But this does not give
me all the information I need.  Have you tried to profile on Solaris?

>
> >  Anyway,
> > ldap_sasl_interactive_bind_s() frees
> > SASL_INTERACT prompt result, but I do not think it frees
> > other prompt buffers.
> > I looked throught sources for ldapsearch and slurpd, but I
> > did not find ways to
> > free the buffers allocated in _ldap_interact.
>
> It appears that _ldap_interact doesn't need to malloc the result at all. We
> can fix this easily enough. However there appear to be more leaks in Cyrus

True.  I tried without malloc and it works fine.  However, the leak is
still there.  There is something else wrong.

> SASL itself, at least with the DIGEST-MD5 mech. I haven't profiled my
> libsasl2 yet so I haven't tracked these down.

I'll try to profile libsasl2 as well and see if I can dig something up.

-- 
Igor