Re: SLAPI (ITS#2073)

[ando@sys-net.it]

Steve,

I've uploaded a patch to

http://www.sys-net.it/~ando/Download/Pierangelo-Masarati-20021104-Steve-Omrani.ns_slapi_.diff

which includes the porting of your submission
to current HEAD code and some fixes.  Among these
you should carefully review "slapi_ops.c" because
there is a number of pointers that are used
uninitialized (significantly the pointer to the
Backend structure, "be"). Other fixes are related
to slapi API functions, like the (apparently)
inconsistent use of slapi_strlen()/slapi_ch_stlen()
(none of which is defined).  I also get very scary
warnings from libtool because you statically link
some libtmpslapd.a to libslapi (if I get it correctly)
in an unportable manner.

Note that I didn't check the functionality of SLAPI
itself (this will require a little more); I only
verified that I can compile OpenLDAP safely and
that the usual tests run OK.

In case you think my changes are appropriate, send
me a note (or a patch with further fixes) and I'll
commit everything.

Of course, any other comment or review is welcome
before I actually commit the patch.

Pierangelo.

-- 
Pierangelo Masarati
mailto:pierangelo.masarati@sys-net.it