slapd crash on modrdn - newSuperior (ITS#2076)

[asparks@quris.com]

Full_Name: Alan Sparks
Version: 2.1.4
OS: Solaris 7
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (208.169.18.3)


slapd crashes after running a command similar to:

ldapmodrdn -h myhost -r -D "uid=me,dc=quris,dc=com" -w pass
"cn=trackit1.quris.net,ou=hosts,dc=quris,dc=com" "cn=trackit.quris.com"

Backtrace:
(gdb) where
#0  0xff136f54 in strlen () from /usr/lib/libc.so.1
#1  0xff181900 in _doprnt () from /usr/lib/libc.so.1
#2  0xff18334c in fprintf () from /usr/lib/libc.so.1
#3  0x76cf4 in replog1 (ri=0x0, op=0x361598, change=0xfd001bc0, fp=0x29a628,
    first=0x0) at repl.c:375
#4  0x76218 in replog (be=0x2aac30, op=0x361598, dn=0xfd001c20,
    ndn=0xfd001c00, change=0xfd001bc0) at repl.c:183
#5  0x654c8 in do_modrdn (conn=0x31a078, op=0x361598) at modrdn.c:354
#6  0x412c8 in connection_operation (arg_v=0x2f5920) at connection.c:960
#7  0xf453c in ldap_int_thread_pool_wrapper (xpool=0x29e7d0) at tpool.c:401

The reference to repl.c:375 shows a test against NULL, but it looks like a NULL
cannot be there given the assignment at modrdn.c:354:

moddn.newsup = &pnewSuperior         (address of var can't be null)