Re: JLDAP Bug n fixes (ITS#1512)

[vtag@novell.com]

Dane,

Thanks for your well documented bug report, and the attached test
program.
I am now reviewing your changes.

-Steve

------------------------
Steve Sonntag
Novell, Inc., the leading provider of Net services software



>>> <dfoster@equitytg.com> 06-Jan-02 2:07:55 PM >>>
Full_Name: Dane Foster
Version: n/a
OS: WIN2K /Linux
URL: ftp://ftp.openldap.org/incoming/jldapFilez.tar.gz 
Submission from: (NULL) (216.242.111.6)


- There is a NullPointerException being thrown in the copy constructor
of the
<code>org.ietf.ldap.LDAPAttribute</code> class.

- There is ClassCastException being thrown by the
<code>removeValue</code>
method of <code>com.novell.ldap.LDAPAttribute</code> if you set the
value of an
attribute using a byte array instead of a String.

- The <code>size</code> method of
<code>com.novell.ldap.LDAPAttribute</code>
incorrectly reports the number of values for an attribute if any of the
values
are <code>null</code>.  This is open to debate because one may argue
for or
against that <code>null</code> is a valid value.  I've chosen the
latter and
thus consider the behavior a bug.

- I've included a JUnit TestCase class that can reproduce the problem. 
Please
note, the patch that I've made is not simply fixes for the bugs but was
a
rewrite of a large portion of the
<code>com.novell.ldap.LDAPAttribute</code>
class.  The JUnit testcase was written to ensure that my changes would
not
introduce new bugs into the JLDAP API.