Bug Fix: attribute names/ordering in search returns (ITS#787)

[baccala@freesoft.org]

Full_Name: Brent Baccala
Version: 2.0.4
OS: Linux Redhat 6.2
URL: http://www.freesoft.org/bbaccala/servers.slapd.result.patch
Submission from: (NULL) (63.216.69.197)


Current openldap-2.0.4 implementation returns canonical names in search
results,
even if the client requested an alias.  For example, core.schema defines
"surname"
as an alias for "sn" (since "sn" is listed first in the schema definition).
Thus, a client search request for "surname" will return "sn".  This is probably
a protocol violation, since RFC 2251 states that search results will contain
attributes "as specified in the attributes field of the Search Request".  Also,
it doesn't make much sense this way - the client should be given what it asked
for.

Also, the openldap-2.0.4 implementation returns attributes in the internal
order they were pulled out of the database.  At least one client (Microsoft
NetMeeting) can't handle this - it expects the attributes in the result to
be in the same order they were requested in the search.  Although the standard
is unclear on this point, it makes sense to be conservative in dealing with
clients, and hand them back exactly what they asked for, in the order they
asked for it.

The referenced patch addresses both of these issues, returning attributes to
the clients in the order requested, using the names requested.