[Date Prev][Date Next] [Chronological] [Thread] [Top]

suspect construct in openldap-19981116



There is a suspect construct in slapd/modify.c (do_modify):

		if ( ber_scanf( op->o_ber, "{i{a[V]}}", &(*modtail)->mod_op,
		    &(*modtail)->mod_type, &(*modtail)->mod_bvalues )
		    == LBER_ERROR )
		{
			send_ldap_result( conn, op, LDAP_PROTOCOL_ERROR, NULL,
			    "decoding error" );
			free( dn );
			free( odn );
			free( *modtail );
--- I don't think *modtail should be freed here
			modlist_free( mods );
			return;
		}

Regards

J.Pietschmann